Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hasher bound on map and set ser/de #16

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

austinabell
Copy link
Contributor

Backport of changes I needed on Serum's fork https://github.com/project-serum/borsh-rs/pull/1

There is no need for the Hasher to be constrained to the default for serialize/deserialize impls

@ailisp
Copy link
Member

ailisp commented Mar 9, 2021

Code looks good, however this doesn't build (see ci) when cargo test --verbose --no-default-features, default-feature currently is ["std"]. can you make this change only happen when std?

@austinabell
Copy link
Contributor Author

Code looks good, however this doesn't build (see ci) when cargo test --verbose --no-default-features, default-feature currently is ["std"]. can you make this change only happen when std?

Oops, I had fixed before but forgot to push

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ailisp ailisp merged commit b510429 into near:master Mar 10, 2021
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants