feat: BorshSerialize/BoshDeserialize/BorshSchema for Cell/RefCell
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ib types It's basically the same as the serde implementations from 5 years ago serde-rs/serde#882 .
dj8yfo
requested changes
Dec 7, 2023
|
@Fuuzetsu , btw, what is your motivation to add support for these types? |
dj8yfo
changed the title
BorshSerialize/BoshDeserialize/BorshSchema for Cell/RefCell
We have a I added Mutex/RwLock as a whole-sale "internal mutability" types though we don't currently serialise these ourselves. I'll address the comments soon, removing Mutex/RwLock. |
dj8yfo
reviewed
Feb 27, 2024
dj8yfo
approved these changes
Feb 27, 2024
Merged
|
Thank you for getting this through. Sorry, I didn't have the time allocation to finish it up... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's basically the same as the serde implementations from 5 years ago serde-rs/serde#882 .