Implemented (de)serialization for nonzero integer

[real-felix]

No description provided.

[austinabell]

Mutually exclusive with #35. This one is more concise and more tests, but also was opened later

[real-felix]

Do you know when it's reviewed? I need this change, and there're very few line to review.

[matklad]

Yeah, let's merge this, the impl and tests look good to me!

[matklad]

🤦 travis refuses to go away, opened https://near.zulipchat.com/#narrow/stream/308449-nearinc.2Fcore-tools/topic/borsh.20repo.20admin

[real-felix]

facepalm travis refuses to go away, opened https://near.zulipchat.com/#narrow/stream/308449-nearinc.2Fcore-tools/topic/borsh.20repo.20admin

I hope it'll be solved soon 😛
I think that the error message could be better, because it's a bit cryptic for now. What do you think about "Zero value read for a NonZero integer" or something like that? (I'm not a native English speaker, I'm not sure about how bad this sounds).

[matklad]

or something like that?

No strong feelings one way or another. My heuristic would be to check what serde_json does and copy that without much extra delibiration.

[real-felix]

My heuristic would be to check what serde_json does and copy that without much extra delibiration.

Did that, thanks! I think it's important that people understand easily what happens when reading an error message.

[real-felix]

@frol Thanks for the merge. Is it possible to publish this change (maybe as a patch version?)

[frol]

@miraclx Are you actively working on getting the automated publishing pipeline for borsh-rs or should I publish it manually for now?

[miraclx]

It's complete, pending review: #67

[miraclx]

Released on https://github.com/near/borsh-rs/releases/tag/v0.9.2

Crate Links

• borsh: https://crates.io/crates/borsh/0.9.2
• borsh-derive: https://crates.io/crates/borsh-derive/0.9.2
• borsh-derive-internal: https://crates.io/crates/borsh-derive-internal/0.9.2
• borsh-schema-derive-internal: https://crates.io/crates/borsh-schema-derive-internal/0.9.2