Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move build,build_extended logic to lib #208

Merged
merged 14 commits into from
Aug 21, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 20, 2024

builder field in ABI json now looks like this:

...
{
  "schema_version": "0.4.0",
  "metadata": {
    "name": "donation-sample-single-package-no-workspace",
    "version": "0.7.7",
    "build": {
      "compiler": "rustc 1.80.1",
      "builder": "cargo-near cargo-near-build 0.1.0"
    }
  },
...  

interop of older 0.6.3 build script with docker image from pr - Cargo.toml
(cargo check runs in Finished dev profile [unoptimized + debuginfo] target(s) in 1m 03s

older_build_rs_in_newer_image

sha256sum *.wasm
2d4a6cd07d59aeacefd7ed73aa58c106bbf23f0b10dd8f56960944fe785cee90  donation-product.repro-fct-45.testnet.wasm
f2e956ed163039c0f341a5048d9260217d4ec0d685fcf1e497222e4234bb47a5  repro-fct-45.testnet.wasm
2d4a6cd07d59aeacefd7ed73aa58c106bbf23f0b10dd8f56960944fe785cee90  repro-fct-product-45.testnet.wasm

interop of newer 0.1.0 cargo-near-build build script (from pr) with older docker image - Cargo.toml

( cargo check runs in Finished dev profile [unoptimized + debuginfo] target(s) in 11.62s)

older_image_with_new_build_rs

sha256sum *.wasm
ad162718dd5cd43d46e5fb8db90f59bf777940def53884c4287a8f8b6f16b054  donation-product.repro-fct-46.testnet.wasm
cf5b9dc7c9c01a28fcb2209339f01d91f3edc144a20714626c1087aa9ee23e00  repro-fct-46.testnet.wasm
ad162718dd5cd43d46e5fb8db90f59bf777940def53884c4287a8f8b6f16b054  repro-fct-product-46.testnet.wasm

@dj8yfo dj8yfo marked this pull request as ready for review August 21, 2024 21:34
@dj8yfo dj8yfo requested a review from frol August 21, 2024 21:37
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Aug 21, 2024

@race-of-sloths ping

@race-of-sloths
Copy link

race-of-sloths commented Aug 21, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 13

Your contribution is much appreciated with a final score of 13!
You have received 137 (130 base + 5% lifetime bonus) Sloth points for this contribution

@dj8yfo, welcome to the Hall of Sloth fame! You have been honored with a Bronze rank and a 5% lifetime bonus to all rating points you earn with your next contributions!

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dj8yfo great job! Once we will approach the final stage, we'd need to review all the public structs and functions and minimize their number to keep the public interface minimal

@race-of-sloths score 13

@frol frol merged commit 822df45 into extract_lib_with_eyre Aug 21, 2024
14 checks passed
@frol frol deleted the move_build_logic branch August 21, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants