Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add w-near nep-146, nep-145, nep-148 #128

Closed
wants to merge 5 commits into from
Closed

Add w-near nep-146, nep-145, nep-148 #128

wants to merge 5 commits into from

Conversation

evgenykuzyakov
Copy link
Collaborator

No description provided.

@ilblackdragon ilblackdragon mentioned this pull request Feb 21, 2021
Merged
@ilblackdragon
Copy link
Member

ilblackdragon commented Feb 21, 2021 •
edited
Loading

Moved the interfaces and basis of the implementation into near/near-sdk-rs#293

wNEAR implementation can be just adding methods for wnear_deposit and wnear_withdraw
Plus IMO it should auto register accounts on wnear_deposit if the amount of NEAR is above the required for an account -- there is now method internal_register_account specifically for that. wnear_withdraw can check if there is anything left and call unregister in the case everything was withdrawn.

@ilblackdragon ilblackdragon mentioned this pull request Feb 21, 2021
Closed
@evgenykuzyakov
Copy link
Collaborator Author

Closing in favor of #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberrytech jberrytech Awaiting requested review from jberrytech jberrytech will be requested when the pull request is marked ready for review jberrytech is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgenykuzyakov @ilblackdragon