Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: wsl set default version #2189

Merged
merged 2 commits into from
Aug 12, 2024
Merged

doc: wsl set default version #2189

merged 2 commits into from
Aug 12, 2024

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Jul 30, 2024

@dj8yfo dj8yfo requested a review from bucanero as a code owner July 30, 2024 10:21
@frol
Copy link
Collaborator

frol commented Jul 30, 2024

@flmel Could you, please, review it?

@race-of-sloths
Copy link

race-of-sloths commented Jul 30, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
King of Sloths shakes your hand! Yellow leader's jersey is yours deservedly!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 45 (20 base + 25 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @dj8yfo! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@flmel
Copy link
Member

flmel commented Jul 31, 2024

Hey @dj8yfo the reason for skipping on setting the default version (or suggesting any version in general) is that its not always possible to use v2 out of the box. On the VM and one of the natively running machines I tested, due to some bios settings it wasn't possible to use wsl v2, only setting the version to v1 worked. I can find the issue if dig a bit.

What is the direct impact for you if the default wsl version is not explicitly set to v2? Maybe we can add an TIP section mentioning these scenarios?

@dj8yfo
Copy link
Contributor Author

dj8yfo commented Aug 1, 2024

@flmel well, i tested on a vm windows 10, and it worked.
Also i found that it's easier to set a default version first, than try to convert a v1 distro to v2 later, which actually failed in my case.
It may be made a recommendation tip only for sure.
If it doesn't work, well, alas.
cargo-near will now work via docker by default, and docker is enabled relatively easy from inside wsl2 distros if it was installed with WsL2 backend https://docs.docker.com/desktop/install/windows-install/

@flmel flmel merged commit ca8843b into near:master Aug 12, 2024
2 of 3 checks passed
@race-of-sloths
Copy link

🥁 Score it!

@flmel, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

4 participants