feat(near-api-js): wallet sign-in page redirection is now optional #1025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, we want the sign-in process not to redirect the whole page, but to be open in a popup window.
As mentioned in #1010
Description
She added to different methods (
requestSignInLink
,requestSignInLink
, andcompleteSignInWithAccessKeyLink
) to theWalletConnection
, to get the needed URLs to the NEAR wallet in order to manually process them like in a popup or _blank redirection.Checklist