Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(near-api-js): wallet sign-in page redirection is now optional #1025

Closed
wants to merge 5 commits into from

Conversation

DevSlashRichie
Copy link

@DevSlashRichie DevSlashRichie commented Nov 1, 2022

Motivation

Sometimes, we want the sign-in process not to redirect the whole page, but to be open in a popup window.
As mentioned in #1010

Description

She added to different methods (requestSignInLink, requestSignInLink, and completeSignInWithAccessKeyLink) to the WalletConnection, to get the needed URLs to the NEAR wallet in order to manually process them like in a popup or _blank redirection.

Checklist

  • Read the contributing guidelines
  • Commit messages follow the conventional commits spec
  • Performed a self-review of the PR
  • Added automated tests (The methods added are already tested as they are executed by the ones with a written test)
  • Manually tested the change

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

⚠️ No Changeset found

Latest commit: 30f6fa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frol
Copy link
Collaborator

frol commented Jun 28, 2023

@DevSlashRichie We are bringing near-api-js back to be actively maintained. This change makes total sense to me, but it needs to be rebased now (probably faster to just manually re-implement it as a lot of files have actually moved to other places). Do you have the capacity to rebase?

@denbite
Copy link
Contributor

denbite commented Jan 14, 2024

the idea of having methods for generating a Wallet URL without redirecting looks also reasonable to me and was implemented in #1260

I'd suggest closing this one so we don't leave it out of date

@vikinatora
Copy link
Collaborator

Resolved by #1260.

@vikinatora vikinatora closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants