feat: multi public-key for account delete-key command #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mehrbod2002 Thanks for the contribution! @FroVolod Please, review this PR. It seems that it does not have checkbox-list in the interactive mode and instead asks a user to specify public keys as a comma-separated list, but it might be already good enough for the time being while checkbox-list can be implemented later. |
frol
requested changes
May 30, 2023
frol
reviewed
May 30, 2023
frol
reviewed
May 30, 2023
|
@Mehrbod2002 I left a few comments here and there, and @FroVolod fixed a few places with a commit. Please, address the remaining items, and let's merge it. |
|
@frol Now you can review it . |
frol
approved these changes
May 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #205
multi public-key for account delete-key command separated by
,.