Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed parsing account id for fetching active staking pools #369

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Jul 15, 2024

What was wrong

The provided string contained a data prefix before the account id name that prevented the function from parsing the AccountId
Also, I extracted the filter into the call itself
See image:
image

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jul 15, 2024

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
You are true leader! Other sloths hot on your heels, keep moving!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 3

The average score is 3

@akorchyn check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol
Copy link
Collaborator

frol commented Jul 15, 2024

@race-of-sloths score 3

@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@frol frol merged commit 8edb18d into near:main Jul 15, 2024
9 checks passed
@frol frol mentioned this pull request Jul 15, 2024
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 3!
You have received 50 (30 base + 20 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @akorchyn! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

frol added a commit that referenced this pull request Jul 30, 2024
## 🤖 New release
* `near-cli-rs`: 0.12.0 -> 0.13.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.13.0](v0.12.0...v0.13.0)
- 2024-07-30

### Added
- Automatically exec legacy JS CLI commands for full backward
compatibility ([#366](#366))
- Added the ability to use the TEACH-ME mode
([#360](#360))
- Added a new subcommand to edit configuration parameters
([#367](#367))

### Fixed
- Fixed the fallback implementation of fetching active staking pools
([#369](#369))

### Other
- Fixed typos in user prompts and the guide
([#372](#372))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants