This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
View state #684
Merged
View state #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Mar 3, 2021
volovyks
reviewed
Mar 4, 2021
| const { formatResponse } = require('../utils/inspect-response'); | ||
|
|
||
| module.exports = { | ||
| command: 'view-state <account-id> [prefix]', |
There was a problem hiding this comment.
Semantically it's the same as state. Should we rename it to view-contract-state, or simply contract-state? @mikedotexe @evgenykuzyakov @chadoh need your opinion here.
There was a problem hiding this comment.
Once we have the namespaces proposed in near/NEPs#31, I would advocate for near contract state. But I doubt it makes sense to do that for now.
In the meantime, I don't have a strong preference. near view-state some-contract.near seems fine to me.
There was a problem hiding this comment.
I'll just roll as is then and makes sense to me to change to namespaces long term.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.