Change search

[matiasbenary]

That is done:
The search works for docs and for catalog.
When you click on docs it takes you inside the page.
Within apps when you click on the title it takes you where it belongs, you can also click on the tag.

Missing:
Missing components, I don't quite understand the filters I was using.
Separate in component and improve the styles.
Missing the full view of search when you search in mobile.
When you click to close
Paginated and see all
Order the code

[vercel]

@matiasbenary is attempting to deploy a commit to the Near Developer Console Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
beta.near.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 0:07am
dev-near-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2024 0:07am
near-discovery-testnet	❌ Failed (Inspect)			Jul 25, 2024 0:07am

[gagdiez]

@shelegdmitriy we might need some help with css here, is that something you could help with? otherwise I'll see to dust off my css foo

cc @charleslavon

[shelegdmitriy]

@shelegdmitriy we might need some help with css here, is that something you could help with? otherwise I'll see to dust off my css foo

cc @charleslavon

Sure I can help you here! Let me check the PR and I'll respond in a while

[shelegdmitriy]

@matiasbenary may I ask you to fix CI/Lint please?

[matiasbenary]

@matiasbenary may I ask you to fix CI/Lint please?

I fixed it

[denbite]

typo -> algoliaSearchApi.ts

[shelegdmitriy]

Issue 1

Clicking on -> arrow on the "Components" tab leads to error

cc @matiasbenary @gagdiez

[shelegdmitriy]

Issue 2

Search input is broken if sidebar is collapsed. On dev.near.org it works fine:

[shelegdmitriy]

I thought we decided to show this search input with dropdown for desktop devices only? I'd propose to stick to the current implementation: mobile only have a search icon which leads to search page. If you wish to improve this later - create a task.

cc @gagdiez

[shelegdmitriy]

Hey @matiasbenary and @gagdiez. I see you did a lot of progress here. There is a room for improvements and I would like to help you but may I ask you to fix this issue 1 please?

[shelegdmitriy]

Also, @matiasbenary ping me please after you fix issue 1 please so I could pull your branch to make some additional changes, ok?

[matiasbenary]

Issue 1
The error is also in production, and is due to a component error.
There are components that work well and others that have some errors

Issue 2

• fixed broken images in the component browser
• changed navbar button redirection in mobile
• added filter for components api
• fixed styles and hide input when collapsed
  

[gagdiez]

I think the issue 1 is because we are soft-loading the page through a router, and not hard-refreshing the page. This keeps the state, and confuses the VM sometimes @matiasbenary

[gagdiez]

@shelegdmitriy while I was not able to reproduce the error that you and @matiasbenary have, and I see that Matias was able to reproduce it in the current version of dev.near.org

I think it is related to another issue, which is how we handle components and the VM in general: #1264

I would suggest to leave this for another time, as it is an already existing bug

[shelegdmitriy]

Hey @gagdiez @matiasbenary @charleslavon. I believe I added everything I'd like to this PR so feel free to review this and leave your questions. One thing I want to highlight is new <Input /> component. Actually, it was implemented by @calebjacob here and polished in our ticketing repo so I copied that because it already has a lot of we need (and maybe even more) and it's fully aligned with current color scheme. This means, I would recommend you to use it in your future refactoring rounds.

FYI: a lot of components are already implemented here and there was a preview page for all of them but I can't find it.

[shelegdmitriy]

LGTM!

[gagdiez]

@race-of-sloths I summon you!

[race-of-sloths]

🙁 This repository is not a part of the Race of Sloths

Please ask the maintainer to contact us to join the race!

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag us inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!