This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
feat: add methods enum #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// This makes it easier to get the correct method strings to use when using | ||
| /// the library. | ||
| pub enum Methods { |
There was a problem hiding this comment.
I think this should be in tests folder though. It's not going to be used in the contract itself, right?
There was a problem hiding this comment.
Depends if people are going to use the library as well, if not, then yeah can just live in the tests but, then thats just inflating it a bit. Would users be using the contract module directly at all?
There was a problem hiding this comment.
No, I don't think the contract would be used as a library. And we do want to avoid inflating the contract size.
|
Closing as per the earlier conversation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the tests, this made quite a bit of sense to easily get a list of available methods without actually having to look at the code itself and potentially get confused that the method names themselves should be input as strings. This makes that distinction clearer and should remove some uncertainty from users of the library.