-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gas and storage benchmarks #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! My main concern is that it's better to store benchmark results in separate autogenerated files. It will allow us to update them with time, since gas usage will be constantly changing. But that can be done later, not a blocker now.
pnpm-workspace.yaml
Outdated
@@ -2,3 +2,4 @@ packages: | |||
- "examples" | |||
- "tests" | |||
- "packages/*" | |||
- "bench" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
pnpm-workspace.yaml
Outdated
@@ -2,3 +2,4 @@ packages: | |||
- "examples" | |||
- "tests" | |||
- "packages/*" | |||
- "bench" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Bench" gives me wrong associations. Maybe "benchmark" is better?
bench/src/lowlevel-minimal.js
Outdated
import { near } from "near-sdk-js"; | ||
|
||
export function empty() { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lots of new empty lines at the end of files
Add benchmark, readme and tips to benchmark your use case.