Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update libs and examples to 2021 edition Rust #669

Merged
merged 4 commits into from
May 25, 2022

Conversation

austinabell
Copy link
Contributor

Requires updating the released https://hub.docker.com/r/nearprotocol/contract-builder dockerfile to use > Rust 1.56 to avoid having to use a local dockerfile

@austinabell austinabell marked this pull request as ready for review April 11, 2022 19:14
@austinabell
Copy link
Contributor Author

Second-guessing doing this in this upcoming release. Wondering if updating this will cause issues for people using old docker images without sufficient Rust version for this. I'm thinking this should come in the release after 4.0 stable

@austinabell austinabell marked this pull request as draft April 11, 2022 21:49
@austinabell austinabell marked this pull request as ready for review May 25, 2022 01:07
@austinabell
Copy link
Contributor Author

Second-guessing doing this in this upcoming release. Wondering if updating this will cause issues for people using old docker images without sufficient Rust version for this. I'm thinking this should come in the release after 4.0 stable

Given nearcore dependencies requiring Rust 2021 and less unknowns with including as a major version bump, going to include this with 4.0 stable

@austinabell austinabell merged commit c212e7c into master May 25, 2022
@austinabell austinabell deleted the austin/2021ed branch May 25, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants