chore: deprecate upgrade standards implementation #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
approved these changes
Jun 27, 2022
|
@ChaoticTempest noting that the CI had a failure with the same error as before, just to note the non-deterministic failures are still happening after the patch update pulled in (maybe less frequent, unclear yet) |
|
@austinabell hmm, weird. Yeah keep updating me about these. Might need to up it via the env var to 100 secs, or maybe its not even a timeout issue happening, but that the sandbox node wasn't able to start up. If its the latter that's the issue, the error should have been reported earlier on... It could be that GH has a shared CPU behind its task scheduling, so you get bursty workloads that leads to this non-determinism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure why this was added, somewhat broken as per #855 and the interface doesn't make much sense and is inefficient.
Deprecating for now and can optimize/update if there are real use cases or the standard is actually added to NEPs