fix(js): type in generating account ids #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
fix/account_name_generator
branch
from
b7e838e
to
9f60832
Compare
|
@volovyk-s Thoughts? |
volovyks
reviewed
Nov 18, 2021
| @@ -53,7 +53,7 @@ export async function captureError(fn: () => Promise<any>): Promise<string> { | |||
| } | |||
|
|
|||
| export function isTopLevelAccount(accountId: string): boolean { | |||
| return accountId.includes('.'); | |||
There was a problem hiding this comment.
Why are we making this change?
There was a problem hiding this comment.
The logic was wrong. A top level account is one without an . not with one.
volovyks
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
}left over at the end