Existence of validator signer should not be used to check is-validator condition #11821
Assignees
Comments
staffik
changed the title
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 23, 2024
See #11821 for context. Check if this is a current validator using current epoch info, not merely the fact that validator key exists. # Testing ## Current Mainnet (protocol version 67) Pre-requirements for the check to kick-in: * `tracked_shards=[]` in `config.json` * `validator_key.json` exists Tested with different validator IDs: * `node` - dummy validator ID, it **did not** crash * `gritsly.poolv1.near` - existing validator with the lowest stake, not marked as `CP` in the debug page, it **did not** crash * `solidstate.poolv1.near` - existing validator with the lowest stake that was marked as `CP` in the debug page, it **crashed** ## Current Testnet (protocol version 69) Pre-requirements for the check to kick-in: * `tracked_shards=[0]` in `config.json` * `validator_key.json` exists Tested with different validator IDs: * `node` - dummy validator ID, it **did not** crash * `lavenderfive.pool.f863973.m0` - existing validator with the lowest stake, not marked as `CV` in the debug page, it **did not** crash * `snsmlnn.pool.f863973.m0` - existing validator with the lowest stake that was marked as `CV` in the debug page, it **crashed**
marcelo-gonzalez
pushed a commit
that referenced
this issue
Jul 24, 2024
See #11821 for context. Check if this is a current validator using current epoch info, not merely the fact that validator key exists. # Testing ## Current Mainnet (protocol version 67) Pre-requirements for the check to kick-in: * `tracked_shards=[]` in `config.json` * `validator_key.json` exists Tested with different validator IDs: * `node` - dummy validator ID, it **did not** crash * `gritsly.poolv1.near` - existing validator with the lowest stake, not marked as `CP` in the debug page, it **did not** crash * `solidstate.poolv1.near` - existing validator with the lowest stake that was marked as `CP` in the debug page, it **crashed** ## Current Testnet (protocol version 69) Pre-requirements for the check to kick-in: * `tracked_shards=[0]` in `config.json` * `validator_key.json` exists Tested with different validator IDs: * `node` - dummy validator ID, it **did not** crash * `lavenderfive.pool.f863973.m0` - existing validator with the lowest stake, not marked as `CV` in the debug page, it **did not** crash * `snsmlnn.pool.f863973.m0` - existing validator with the lowest stake that was marked as `CV` in the debug page, it **crashed**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See related thread: https://near.zulipchat.com/#narrow/stream/407237-core.2Fstateless-validation/topic/bug.20in.20tracked.20shards/near/452604183
In general a node could have a validator key and initialize the validator signer using it, but existence of validator signer should not be used to check if the node is currently a validator.
The text was updated successfully, but these errors were encountered: