Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with stable Rust #2260

Closed
3 of 4 tasks
frol opened this issue Mar 14, 2020 · 3 comments · Fixed by #4168
Closed
3 of 4 tasks

Compile with stable Rust #2260

frol opened this issue Mar 14, 2020 · 3 comments · Fixed by #4168
Labels
A-security Area: Security issues C-housekeeping Category: Refactoring, cleanups, code quality
Milestone

Comments

@frol
Copy link
Collaborator

frol commented Mar 14, 2020

Currently, nearcore can only be compiled with nightly Rust compiler due to the following unstable features:

It seems that we can have nearcore compiled on stable Rust once proc_macro_hygiene is stabilized (mid June?) and dynasm has unstable features under feature flags.

/cc @nearmax @bowenwang1996

@frol frol added C-housekeeping Category: Refactoring, cleanups, code quality A-security Area: Security issues help wanted labels Mar 14, 2020
@ilblackdragon ilblackdragon added this to the Post MainNet milestone Mar 19, 2020
@frol
Copy link
Collaborator Author

frol commented Jul 1, 2020

dynasm-rs 0.7 release should be compilable on stable Rust 1.45 release (the release is scheduled for July 16th), so it seems that it is only a matter of wasmer singlepass backend to upgrade to dynasm-rs 0.7 release (wasmerio/wasmer#1488).

/cc @nearmax @olonho

@olonho
Copy link
Contributor

olonho commented Jul 1, 2020

Great to know!

@frol
Copy link
Collaborator Author

frol commented Jul 20, 2020

dynasm-rs has its 1.0 release (they decided to have this milestone of compilation on stable Rust 1.45+ clearly communicated).

wasmer needs to migrate to this new version and they claim that the support is already addressed in their new refactored version of wasmer:

We are working on the new version of Wasmer that will be released to the public soon.

In this new version we are already using the latest version of Cranelift (that also supports Aarch64), and have passed all tests successfully in our ARM servers.

So we just have to wait for a few weeks to see the support upstream! :)

@mikhailOK mikhailOK linked a pull request Mar 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-security Area: Security issues C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants