Stabilize fn-like proc macros in expression, pattern and statement positions #68717

petrochenkov · 2020-01-31T22:33:33Z

I.e. all the positions in which stable macro_rules macros are supported.

Depends on #68716 ("Stabilize Span::mixed_site").

cc #54727
cc #54727 (comment)

Stabilization report: #68717 (comment).

rust-highfive · 2020-01-31T22:33:38Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2020-02-11T05:14:03Z

☔ The latest upstream changes (presumably #68929) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2020-02-16T10:11:53Z

This is still waiting on me writing the stabilization report, but it's also blocked on #68716.

Centril · 2020-04-13T03:12:56Z

r? @Centril

Dylan-DPC-zz · 2020-04-15T18:06:59Z

r? @varkor

Stabilize `Span::mixed_site` Closes rust-lang#65049. cc rust-lang#54727 (comment) Pre-requisite for rust-lang#68717 ("Stabilize fn-like proc macros in expression, pattern and statement positions"). Stabilization report: rust-lang#68716 (comment).

rfcbot · 2020-05-17T19:22:07Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

varkor · 2020-05-18T13:34:13Z

@bors r+

bors · 2020-05-18T13:34:15Z

📌 Commit 5c6f7b3 has been approved by varkor

bors · 2020-05-18T14:24:42Z

⌛ Testing commit 5c6f7b3 with merge ef677e3f09cdcd38e6357c5c04898057b95165d1...

Aaron1011 · 2020-05-18T17:55:40Z

@bors retry

A job was stuck for 3 hours on 'Installing msys2 packages' (https://dev.azure.com/rust-lang/rust/_build/results?buildId=29511&view=logs&j=339a807e-05eb-50a3-f69a-0d7a3a5b2cef), so the build is going to time out.

mati865 · 2020-05-18T18:12:24Z

@Aaron1011 can you close the tree? It's msys2 issue.
I'm working on a workaround in #72332

bors · 2020-05-19T03:11:38Z

⌛ Testing commit 5c6f7b3 with merge 5943351...

bors · 2020-05-19T06:30:06Z

☀️ Test successful - checks-azure
Approved by: varkor
Pushing 5943351 to master...

Stabilize fn-like proc macros in expression, pattern and statement positions I.e. all the positions in which stable `macro_rules` macros are supported. Depends on rust-lang/rust#68716 ("Stabilize `Span::mixed_site`"). cc rust-lang/rust#54727 cc rust-lang/rust#54727 (comment) Stabilization report: rust-lang/rust#68717 (comment).

Fn-like procedural macros in expression positions were stabilized in <rust-lang/rust#68717>.

While here clean up all pkglint warnings. Changes since 1.44.1: Version 1.45.2 (2020-08-03) ========================== * [Fix bindings in tuple struct patterns][74954] * [Fix track_caller integration with trait objects][74784] [74954]: rust-lang/rust#74954 [74784]: rust-lang/rust#74784 Version 1.45.1 (2020-07-30) ========================== * [Fix const propagation with references.][73613] * [rustfmt accepts rustfmt_skip in cfg_attr again.][73078] * [Avoid spurious implicit region bound.][74509] * [Install clippy on x.py install][74457] [73613]: rust-lang/rust#73613 [73078]: rust-lang/rust#73078 [74509]: rust-lang/rust#74509 [74457]: rust-lang/rust#74457 Version 1.45.0 (2020-07-16) ========================== Language -------- - [Out of range float to int conversions using `as` has been defined as a saturating conversion.][71269] This was previously undefined behaviour, but you can use the `{f64, f32}::to_int_unchecked` methods to continue using the current behaviour, which may be desirable in rare performance sensitive situations. - [`mem::Discriminant<T>` now uses `T`'s discriminant type instead of always using `u64`.][70705] - [Function like procedural macros can now be used in expression, pattern, and statement positions.][68717] This means you can now use a function-like procedural macro anywhere you can use a declarative (`macro_rules!`) macro. Compiler -------- - [You can now override individual target features through the `target-feature` flag.][72094] E.g. `-C target-feature=+avx2 -C target-feature=+fma` is now equivalent to `-C target-feature=+avx2,+fma`. - [Added the `force-unwind-tables` flag.][69984] This option allows rustc to always generate unwind tables regardless of panic strategy. - [Added the `embed-bitcode` flag.][71716] This codegen flag allows rustc to include LLVM bitcode into generated `rlib`s (this is on by default). - [Added the `tiny` value to the `code-model` codegen flag.][72397] - [Added tier 3 support\* for the `mipsel-sony-psp` target.][72062] - [Added tier 3 support for the `thumbv7a-uwp-windows-msvc` target.][72133] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`net::{SocketAddr, SocketAddrV4, SocketAddrV6}` now implements `PartialOrd` and `Ord`.][72239] - [`proc_macro::TokenStream` now implements `Default`.][72234] - [You can now use `char` with `ops::{Range, RangeFrom, RangeFull, RangeInclusive, RangeTo}` to iterate over a range of codepoints.][72413] E.g. you can now write the following; ```rust for ch in 'a'..='z' { print!("{}", ch); } println!(); // Prints "abcdefghijklmnopqrstuvwxyz" ``` - [`OsString` now implements `FromStr`.][71662] - [The `saturating_neg` method as been added to all signed integer primitive types, and the `saturating_abs` method has been added for all integer primitive types.][71886] - [`Arc<T>`, `Rc<T>` now implement `From<Cow<'_, T>>`, and `Box` now implements `From<Cow>` when `T` is `[T: Copy]`, `str`, `CStr`, `OsStr`, or `Path`.][71447] - [`Box<[T]>` now implements `From<[T; N]>`.][71095] - [`BitOr` and `BitOrAssign` are implemented for all `NonZero` integer types.][69813] - [The `fetch_min`, and `fetch_max` methods have been added to all atomic integer types.][72324] - [The `fetch_update` method has been added to all atomic integer types.][71843] Stabilized APIs --------------- - [`Arc::as_ptr`] - [`BTreeMap::remove_entry`] - [`Rc::as_ptr`] - [`rc::Weak::as_ptr`] - [`rc::Weak::from_raw`] - [`rc::Weak::into_raw`] - [`str::strip_prefix`] - [`str::strip_suffix`] - [`sync::Weak::as_ptr`] - [`sync::Weak::from_raw`] - [`sync::Weak::into_raw`] - [`char::UNICODE_VERSION`] - [`Span::resolved_at`] - [`Span::located_at`] - [`Span::mixed_site`] - [`unix::process::CommandExt::arg0`] Cargo ----- Misc ---- - [Rustdoc now supports strikethrough text in Markdown.][71928] E.g. `~~outdated information~~` becomes "~~outdated information~~". - [Added an emoji to Rustdoc's deprecated API message.][72014] Compatibility Notes ------------------- - [Trying to self initialize a static value (that is creating a value using itself) is unsound and now causes a compile error.][71140] - [`{f32, f64}::powi` now returns a slightly different value on Windows.][73420] This is due to changes in LLVM's intrinsics which `{f32, f64}::powi` uses. - [Rustdoc's CLI's extra error exit codes have been removed.][71900] These were previously undocumented and not intended for public use. Rustdoc still provides a non-zero exit code on errors. Internals Only -------------- - [Make clippy a git subtree instead of a git submodule][70655] - [Unify the undo log of all snapshot types][69464] [73420]: rust-lang/rust#73420 [72324]: rust-lang/rust#72324 [71843]: rust-lang/rust#71843 [71886]: rust-lang/rust#71886 [72234]: rust-lang/rust#72234 [72239]: rust-lang/rust#72239 [72397]: rust-lang/rust#72397 [72413]: rust-lang/rust#72413 [72014]: rust-lang/rust#72014 [72062]: rust-lang/rust#72062 [72094]: rust-lang/rust#72094 [72133]: rust-lang/rust#72133 [71900]: rust-lang/rust#71900 [71928]: rust-lang/rust#71928 [71662]: rust-lang/rust#71662 [71716]: rust-lang/rust#71716 [71447]: rust-lang/rust#71447 [71269]: rust-lang/rust#71269 [71095]: rust-lang/rust#71095 [71140]: rust-lang/rust#71140 [70655]: rust-lang/rust#70655 [70705]: rust-lang/rust#70705 [69984]: rust-lang/rust#69984 [69813]: rust-lang/rust#69813 [69464]: rust-lang/rust#69464 [68717]: rust-lang/rust#68717 [`Arc::as_ptr`]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#method.as_ptr [`BTreeMap::remove_entry`]: https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.remove_entry [`Rc::as_ptr`]: https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#method.as_ptr [`rc::Weak::as_ptr`]: https://doc.rust-lang.org/stable/std/rc/struct.Weak.html#method.as_ptr [`rc::Weak::from_raw`]: https://doc.rust-lang.org/stable/std/rc/struct.Weak.html#method.from_raw [`rc::Weak::into_raw`]: https://doc.rust-lang.org/stable/std/rc/struct.Weak.html#method.into_raw [`sync::Weak::as_ptr`]: https://doc.rust-lang.org/stable/std/sync/struct.Weak.html#method.as_ptr [`sync::Weak::from_raw`]: https://doc.rust-lang.org/stable/std/sync/struct.Weak.html#method.from_raw [`sync::Weak::into_raw`]: https://doc.rust-lang.org/stable/std/sync/struct.Weak.html#method.into_raw [`str::strip_prefix`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.strip_prefix [`str::strip_suffix`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.strip_suffix [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/stable/std/char/constant.UNICODE_VERSION.html [`Span::resolved_at`]: https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.resolved_at [`Span::located_at`]: https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.located_at [`Span::mixed_site`]: https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.mixed_site [`unix::process::CommandExt::arg0`]: https://doc.rust-lang.org/std/os/unix/process/trait.CommandExt.html#tymethod.arg0

rust-highfive assigned varkor Jan 31, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2020

petrochenkov mentioned this pull request Jan 31, 2020

Stabilize Span::mixed_site #68716

Merged

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 31, 2020

jonas-schievink added this to the 1.43 milestone Jan 31, 2020

jonas-schievink added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Jan 31, 2020

petrochenkov mentioned this pull request Jan 31, 2020

Tracking issue for procedural macros and "hygiene 2.0" #54727

Open

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2020

pksunkara approved these changes Feb 1, 2020

View reviewed changes

SergioBenitez mentioned this pull request Feb 16, 2020

Compile with stable Rust rwf2/Rocket#19

Closed

11 tasks

petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 16, 2020

pksunkara approved these changes Feb 19, 2020

View reviewed changes

Centril modified the milestones: 1.43, 1.44 Mar 10, 2020

This was referenced Mar 14, 2020

Compile with stable Rust near/nearcore#2260

Closed

Use on stable Rust? CensoredUsername/dynasm-rs#31

Closed

rust-highfive assigned Centril and unassigned varkor Apr 13, 2020

rust-highfive assigned varkor and unassigned Centril Apr 15, 2020

Dylan-DPC-zz modified the milestones: 1.44, 1.45 Apr 21, 2020

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 17, 2020

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels May 17, 2020

kevinmehall mentioned this pull request May 18, 2020

Add Span::mixed_site, Span::resolved_at, and Span::located_at behind hygiene feature dtolnay/proc-macro2#228

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2020

bors merged commit 5943351 into rust-lang:master May 19, 2020

ehuss mentioned this pull request May 20, 2020

Update fn-like proc-macro invocation restrictions. rust-lang/reference#816

Merged

Emoun mentioned this pull request May 28, 2020

Implicit module name duplication Emoun/duplicate#7

Closed

yvt added a commit to yvt/Stella2 that referenced this pull request May 30, 2020

refactor: stop using proc-macro-hack

14f3588

Fn-like procedural macros in expression positions were stabilized in <rust-lang/rust#68717>.

scrabsha mentioned this pull request Jun 12, 2020

[RFC] Minimal Supported Rust Version gleam-lang/gleam#659

Closed

nitsky mentioned this pull request Jul 8, 2020

IDE support in fn-like proc macro arguments rust-lang/rust-analyzer#5265

Closed

coriolinus mentioned this pull request Jul 10, 2020

futures_util::select! runs into recursion limits rust-lang/futures-rs#1917

Closed

alecmocatta mentioned this pull request Jul 11, 2020

Remove proc macro hack alecmocatta/serde_closure#27

Merged

camelid mentioned this pull request Jul 28, 2020

Section on proc macros is out of date rust-lang/reference#856

Closed

HadrienG2 mentioned this pull request Jan 31, 2021

Is proc_macro_hygiene still needed? jkarns275/f128#30

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize fn-like proc macros in expression, pattern and statement positions #68717

Stabilize fn-like proc macros in expression, pattern and statement positions #68717

petrochenkov commented Jan 31, 2020 •

edited

rust-highfive commented Jan 31, 2020

bors commented Feb 11, 2020

petrochenkov commented Feb 16, 2020

Centril commented Apr 13, 2020

Dylan-DPC-zz commented Apr 15, 2020

rfcbot commented May 17, 2020

varkor commented May 18, 2020

bors commented May 18, 2020

bors commented May 18, 2020

Aaron1011 commented May 18, 2020

mati865 commented May 18, 2020

bors commented May 19, 2020

bors commented May 19, 2020

Stabilize fn-like proc macros in expression, pattern and statement positions #68717

Stabilize fn-like proc macros in expression, pattern and statement positions #68717

Conversation

petrochenkov commented Jan 31, 2020 • edited

rust-highfive commented Jan 31, 2020

bors commented Feb 11, 2020

petrochenkov commented Feb 16, 2020

Centril commented Apr 13, 2020

Dylan-DPC-zz commented Apr 15, 2020

rfcbot commented May 17, 2020

varkor commented May 18, 2020

bors commented May 18, 2020

bors commented May 18, 2020

Aaron1011 commented May 18, 2020

mati865 commented May 18, 2020

bors commented May 19, 2020

bors commented May 19, 2020

petrochenkov commented Jan 31, 2020 •

edited