Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use NightshadeRuntime in store_validator tests #10690

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Mar 1, 2024

Part of #10678 and #10634.

@pugachAG pugachAG added the C-housekeeping Category: Refactoring, cleanups, code quality label Mar 1, 2024
@pugachAG pugachAG requested a review from a team as a code owner March 1, 2024 14:22
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.11%. Comparing base (1ab5d1b) to head (2c2537a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10690      +/-   ##
==========================================
- Coverage   72.16%   72.11%   -0.06%     
==========================================
  Files         737      737              
  Lines      150811   150872      +61     
  Branches   150811   150872      +61     
==========================================
- Hits       108831   108796      -35     
- Misses      37044    37116      +72     
- Partials     4936     4960      +24     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (-0.01%) ⬇️
db-migration 0.24% <ø> (-0.01%) ⬇️
genesis-check 1.40% <ø> (-0.01%) ⬇️
integration-tests 37.09% <0.00%> (+0.08%) ⬆️
linux 70.93% <100.00%> (-0.05%) ⬇️
linux-nightly 71.54% <100.00%> (-0.06%) ⬇️
macos 55.16% <100.00%> (-0.03%) ⬇️
pytests 1.63% <ø> (-0.04%) ⬇️
sanity-checks 1.41% <ø> (-0.01%) ⬇️
unittests 67.94% <100.00%> (-0.07%) ⬇️
upgradability 0.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG requested a review from wacban March 4, 2024 09:29
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pugachAG pugachAG added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit de3b87a Mar 4, 2024
30 checks passed
@pugachAG pugachAG deleted the remove-kv-runtime-1 branch March 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants