refactor: use NightshadeRuntime for chain garabage collection tests #10694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10694 +/- ##
==========================================
+ Coverage 72.14% 72.17% +0.02%
==========================================
Files 737 737
Lines 150858 150862 +4
Branches 150858 150862 +4
==========================================
+ Hits 108843 108879 +36
+ Misses 37055 37025 -30
+ Partials 4960 4958 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
force-pushed
the
remove-kv-runtime-gc-tests
branch
4 times, most recently
from
4f01d6b
to
af0d836
Compare
pugachAG
force-pushed
the
remove-kv-runtime-gc-tests
branch
from
af0d836
to
e0dfc01
Compare
nagisa
reviewed
Mar 4, 2024
nagisa
approved these changes
Mar 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Currently failing on nayduck, was missed as part #10694. Verified the fix with `cargo test -pnear-chain --features test_features,expensive_tests -- --exact --nocapture tests::garbage_collection::test_gc_pine`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10678 and #10634.
Tests are updated to reflect the actual behaviour of chain garbage collection.