Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: remove duplicate field #11337

Merged
merged 1 commit into from
May 17, 2024

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented May 17, 2024

receipt_id already stores that very same info.

@nagisa nagisa requested a review from a team as a code owner May 17, 2024 07:22
@nagisa nagisa requested a review from tayfunelmas May 17, 2024 07:22
@nagisa nagisa enabled auto-merge May 17, 2024 07:22
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (7befdbd) to head (fc5abc1).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11337    +/-   ##
========================================
  Coverage   71.04%   71.05%            
========================================
  Files         782      783     +1     
  Lines      156618   156789   +171     
  Branches   156618   156789   +171     
========================================
+ Hits       111264   111400   +136     
- Misses      40533    40570    +37     
+ Partials     4821     4819     -2     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (-0.01%) ⬇️
db-migration 0.24% <ø> (-0.01%) ⬇️
genesis-check 1.39% <ø> (-0.01%) ⬇️
integration-tests 37.14% <ø> (-0.05%) ⬇️
linux 68.97% <ø> (+0.05%) ⬆️
linux-nightly 70.47% <ø> (-0.05%) ⬇️
macos 52.40% <ø> (+0.08%) ⬆️
pytests 1.61% <ø> (-0.01%) ⬇️
sanity-checks 1.41% <ø> (-0.01%) ⬇️
unittests 65.48% <ø> (+<0.01%) ⬆️
upgradability 0.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagisa nagisa added this pull request to the merge queue May 17, 2024
Merged via the queue into near:master with commit 899cb30 May 17, 2024
29 checks passed
@nagisa nagisa deleted the removes-duplicated-trace-info branch May 17, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants