-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Submit initial version of tracing analysis scripts #11463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into more-tracing
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
…r.rs Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
…into more-tracing
tayfunelmas
requested review from
wacban and
robin-near
and removed request for
wacban
June 3, 2024 19:28
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11463 +/- ##
==========================================
+ Coverage 71.42% 71.43% +0.01%
==========================================
Files 785 785
Lines 158817 158800 -17
Branches 158817 158800 -17
==========================================
+ Hits 113436 113442 +6
+ Misses 40480 40453 -27
- Partials 4901 4905 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis happens in three stages:
raw_trace
service and convert it to the corresponding Python objects representing the spans and events in raw form.There will likely be more changes to polish the format and add more event/span types, but wanted to submit this version as the beginning to track the history of changes later.
We also add update some span/event logs to collect the relevant fields.
Example output json file for Firefox profiler is attached.
profile_pretty.json