Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Submit initial version of tracing analysis scripts #11463

Closed
wants to merge 48 commits into from

Conversation

tayfunelmas
Copy link
Contributor

The analysis happens in three stages:

  1. We fetch the telemetry traces from the raw_trace service and convert it to the corresponding Python objects representing the spans and events in raw form.
  2. We generate the block and shard histories as the intermediate form, collecting the selected spans and events only.
  3. We convert the block and shard histories in the intermediate form to the Firefox profiler input format.

There will likely be more changes to polish the format and add more event/span types, but wanted to submit this version as the beginning to track the history of changes later.

We also add update some span/event logs to collect the relevant fields.

Example output json file for Firefox profiler is attached.
profile_pretty.json

tayfunelmas and others added 30 commits May 6, 2024 13:44
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
…r.rs

Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
@tayfunelmas tayfunelmas requested a review from a team as a code owner June 3, 2024 19:28
@tayfunelmas tayfunelmas requested review from wacban and robin-near and removed request for wacban June 3, 2024 19:28
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (f7679a7) to head (97d4b46).

Files Patch % Lines
chain/client/src/client.rs 50.00% 2 Missing ⚠️
chain/client/src/client_actor.rs 71.42% 0 Missing and 2 partials ⚠️
...nt/src/stateless_validation/chunk_validator/mod.rs 0.00% 1 Missing and 1 partial ⚠️
chain/client/src/chunk_distribution_network.rs 0.00% 0 Missing and 1 partial ⚠️
...src/stateless_validation/state_witness_producer.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11463      +/-   ##
==========================================
+ Coverage   71.42%   71.43%   +0.01%     
==========================================
  Files         785      785              
  Lines      158817   158800      -17     
  Branches   158817   158800      -17     
==========================================
+ Hits       113436   113442       +6     
+ Misses      40480    40453      -27     
- Partials     4901     4905       +4     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (+<0.01%) ⬆️
db-migration 0.24% <0.00%> (+<0.01%) ⬆️
genesis-check 1.37% <0.00%> (+<0.01%) ⬆️
integration-tests 37.44% <50.00%> (-0.02%) ⬇️
linux 68.93% <43.75%> (+<0.01%) ⬆️
linux-nightly 70.92% <50.00%> (-0.01%) ⬇️
macos 52.54% <43.75%> (-0.02%) ⬇️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.38% <0.00%> (+<0.01%) ⬆️
unittests 66.18% <43.75%> (+0.02%) ⬆️
upgradability 0.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tayfunelmas tayfunelmas marked this pull request as draft July 22, 2024 07:10
@tayfunelmas tayfunelmas removed the request for review from robin-near September 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant