[ft-bencmark] move ft-benchmark scripts to separate directory #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11644 +/- ##
==========================================
- Coverage 71.64% 71.63% -0.02%
==========================================
Files 787 787
Lines 160969 160969
Branches 160969 160969
==========================================
- Hits 115333 115310 -23
- Misses 40602 40615 +13
- Partials 5034 5044 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mooori
approved these changes
Jun 21, 2024
| @@ -0,0 +1,22 @@ | |||
| # FT bencmark scripts | |||
There was a problem hiding this comment.
Suggested change
| # FT bencmark scripts | |
| # FT benchmark scripts |
Comment on lines
+3
to
+5
| ## Quick start | ||
|
|
||
| ### Prerequirements |
There was a problem hiding this comment.
Suggested change
| ## Quick start | |
| ### Prerequirements | |
| ## Requirements |
If there's no other section under ## Quick start then I'd just lift "Requirements" one level up.
|
|
||
| ### Prerequirements | ||
|
|
||
| First, make sure that you setted up your db access. About it you can read [here](https://github.com/near/nearcore/blob/master/benchmarks/continous/db/tool/README.md#requirements). |
There was a problem hiding this comment.
Suggested change
| First, make sure that you setted up your db access. About it you can read [here](https://github.com/near/nearcore/blob/master/benchmarks/continous/db/tool/README.md#requirements). | |
| First, make sure that you set up your db access. About it you can read [here](https://github.com/near/nearcore/blob/master/benchmarks/continous/db/tool/README.md#requirements). |
| For running a benchmark you can just use (from `nearcore/`) `python3 benchmarks/continous/scripts/run-ft-benchmark.py`. This command will launch neard, locust traffic generator, collect data and send it to our db connected to grafana. Using this script you also can change parameters of your run: | ||
|
|
||
| ```bash | ||
| python3 benchmarks/continous/scripts/run-ft-benchmark.py --time <BENCHMARK_DURATION> --users <AMOUNT_OF_USERS> --shards <SHARDS> --nodes <NODES> --rump-up <RUMP_UP_RATE> --user <ACTOR_NAME> |
There was a problem hiding this comment.
Suggested change
| python3 benchmarks/continous/scripts/run-ft-benchmark.py --time <BENCHMARK_DURATION> --users <AMOUNT_OF_USERS> --shards <SHARDS> --nodes <NODES> --rump-up <RUMP_UP_RATE> --user <ACTOR_NAME> | |
| python3 benchmarks/continous/scripts/run-ft-benchmark.py \ | |
| --time <BENCHMARK_DURATION> \ | |
| --users <AMOUNT_OF_USERS> \ | |
| --shards <SHARDS> \ | |
| --nodes <NODES> \ | |
| --rump-up <RUMP_UP_RATE> \ | |
| --user <ACTOR_NAME> |
Makes parsing the command easier IMO.
| python3 benchmarks/continous/scripts/run-ft-benchmark.py --time <BENCHMARK_DURATION> --users <AMOUNT_OF_USERS> --shards <SHARDS> --nodes <NODES> --rump-up <RUMP_UP_RATE> --user <ACTOR_NAME> | ||
| ``` | ||
|
|
||
| Where `BENCHMARK_DURATION` is duration of experiment (setup time not included) in format `\d+[smh]` (for example `30s`, `15m`, `2h`). |
There was a problem hiding this comment.
Suggested change
| Where `BENCHMARK_DURATION` is duration of experiment (setup time not included) in format `\d+[smh]` (for example `30s`, `15m`, `2h`). | |
| Where `BENCHMARK_DURATION` is the duration of the experiment (setup time not included) in format `\d+[smh]` (for example `30s`, `15m`, `2h`). |
| Where `BENCHMARK_DURATION` is duration of experiment (setup time not included) in format `\d+[smh]` (for example `30s`, `15m`, `2h`). | ||
| <RUMP_UP_RATE> is integer which means "how many users should be added every second". | ||
|
|
||
| Currently everything (nodes and locust) is running on same machine you run this command, so be careful increasing `NODES`. |
There was a problem hiding this comment.
Suggested change
| Currently everything (nodes and locust) is running on same machine you run this command, so be careful increasing `NODES`. | |
| Currently everything (nodes and locust) is running on same machine you run this command on, so be careful with increasing `NODES`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.