congestion: decrease backpressure sensibility #11651
Conversation
With new limits on outgoing receipts, based on their size, the original parameters for backpressure on outgoing congestion are no longer ideal. Small numbers of receipts in the outgoing buffer will be a common case and should not cause backpressure.
|
Changing parameters as discussed here: https://near.zulipchat.com/#narrow/stream/295558-core/topic/outgoing.20receipts.20size.20limit/near/445084113 I created a new protocol version (82) guessing that we need it for a clean deployment on statlessnet. I'd also be happy to do the changes in version 80 if that's possible, just let me know. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11651 +/- ##
==========================================
- Coverage 71.66% 71.65% -0.02%
==========================================
Files 787 787
Lines 161063 161063
Branches 161063 161063
==========================================
- Hits 115431 115404 -27
- Misses 40584 40608 +24
- Partials 5048 5051 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@wacban do we need to reorder protocol versions again after this PR is merged?
Yes, but let me see if we can squeeze it in to statelessnet today before it's launched. |
|
since we can squeeze it in before the network reset, I moved the changes to version 80 which keeps things simpler |
With new limits on outgoing receipts, based on their size, the original parameters for backpressure on outgoing congestion are no longer ideal. Small numbers of receipts in the outgoing buffer will be a common case and should not cause backpressure.
With new limits on outgoing receipts, based on their size, the original parameters for backpressure on outgoing congestion are no longer ideal. Small numbers of receipts in the outgoing buffer will be a common case and should not cause backpressure.
With new limits on outgoing receipts, based on their size, the original parameters for backpressure on outgoing congestion are no longer ideal. Small numbers of receipts in the outgoing buffer will be a common case and should not cause backpressure.