debug: improve migration test #11655
Conversation
Longarithm
requested review from
akhi3030,
wacban and
jancionear
and removed request for
akhi3030
|
|
||
| # Config to track all shards. | ||
| node_config = { | ||
| "tracked_shards": list(range(NUM_SHARDS)), |
There was a problem hiding this comment.
lol, this never gets old :)
There was a problem hiding this comment.
but it makes sense there? if node stops being a validator, we specifically ask it to continue tracking all shards.
There was a problem hiding this comment.
my point is that any non-empty value for tracked_shards has exactly the same effect
There was a problem hiding this comment.
I've seen a few different conventions such as setting it to [0] or [666] or [0..num_shard] like you've done, they all mean the same
There was a problem hiding this comment.
Ah, okay. I didn't know that all these conventions still work
| @@ -63,7 +63,7 @@ class Executables(typing.NamedTuple): | |||
| def node_config(self) -> typing.Dict[str, typing.Any]: | |||
| return { | |||
| 'local': True, | |||
| 'neard_root': self.root, | |||
| 'near_root': self.root, | |||
There was a problem hiding this comment.
Can you confirm that no other codepath relies on this? I guess just schedule a full nayduck run and see that it doesn't break any tests.
There was a problem hiding this comment.
there are literally 0 occurrences of neard_root :) will do, anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11655 +/- ##
==========================================
+ Coverage 71.59% 71.66% +0.07%
==========================================
Files 787 787
Lines 160736 161063 +327
Branches 160736 161063 +327
==========================================
+ Hits 115072 115426 +354
+ Misses 40631 40591 -40
- Partials 5033 5046 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add unstaking and staking back to the db_migration test. Checking that #11569 would cause this version of test to fail.
Still not covers GC failure of EpochInfo, but that's a good improvement on its own.
Also, refactored to run nodes using
start_cluster, as in other tests, instead ofsubprocess.call. This allows to override genesis and node configs.