fix: ensure test contract compile without warnings #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all of RUSTFLAGS, CARGO_ENCODED_RUSTFLAGS and CARGO_BUILD_RUSTFLAGS are not leaked. The latter is set by our Makefile, to also honor our `.cargo/config` build flags.
nikurt
approved these changes
May 25, 2022
| @@ -43,10 +43,15 @@ fn build_contract(dir: &str, args: &[&str], output: &str) -> Result<(), Error> { | |||
|
|
|||
| fn cargo_build_cmd(target_dir: &Path) -> Command { | |||
| let mut res = Command::new("cargo"); | |||
| res.env_remove("RUSTFLAGS"); | |||
|
|
|||
| res.env_remove("CARGO_BUILD_RUSTFLAGS"); | |||
There was a problem hiding this comment.
Why is this needed? Which flags other than -Dwarnings are being removed?
There was a problem hiding this comment.
We don't strictly speaking need this I think, but this is sort-of defense in depth, to make the build mode isolated in the face of unforeseen future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
make releasefailing