chore: upgrade sysinfo #7156
Merged
chore: upgrade sysinfo #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to use the fork it seems
mina86
approved these changes
Jul 1, 2022
nagisa
approved these changes
Jul 1, 2022
| .get_process(pid) | ||
| .expect("refresh_process succeeds, this should be not None"); | ||
| let proc = | ||
| self.sys.process(pid).expect("refresh_process succeeds, this should be not None"); | ||
| (proc.cpu_usage(), proc.memory()) |
There was a problem hiding this comment.
Not a blocker here, but a more precise way to measure CPU utilization would be to keep track of how much cpu time (this can be read out using something like this crate) have been consumed between the two measurement points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to use the fork it seems