Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links to NEP and implementation PR to feature-stabilization checklist #7288

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Jul 28, 2022

No description provided.

@matklad matklad requested a review from akhi3030 July 28, 2022 09:54
@matklad matklad requested a review from a team as a code owner July 28, 2022 09:54
Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is this the only place where we document the feature stabilization process? I wonder if we need to expand CONTRIBUTING.md to discuss how feature stabilization works. Currently, it just says, add protocol changes to the unreleased section in the changelog.

@matklad
Copy link
Contributor Author

matklad commented Jul 29, 2022

Yeah, I do think we should probably move this from PR template (which I don't think anybody actually ever sees?) to something more prominent. I decided not to think about a better process in this PR though :)

@akhi3030
Copy link
Collaborator

After doing a couple of recent PRs on CONTRIBUTING.md and having seen some of the docs in the carbon language that you showed me, I am thinking about putting some more effort into improving the docs there. It's on my TODO list 😄

@near-bulldozer near-bulldozer bot merged commit b6f0c1f into near:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants