Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added loading spinners during RPC call #894

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: added loading spinners during RPC call #894

merged 1 commit into from
Jul 18, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jul 17, 2024 •
edited
Loading

Screenshot 2024-07-17 at 6 41 33 PM

@Kevin101Zhang Kevin101Zhang linked an issue Jul 17, 2024 that may be closed by this pull request
Add spinner for BOS component as it feels 'broken' when data is fetching #893
Closed
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review July 17, 2024 22:40
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner July 17, 2024 22:40
@Kevin101Zhang Kevin101Zhang merged commit 7dfb2aa into main Jul 18, 2024
4 checks passed
@Kevin101Zhang Kevin101Zhang deleted the 893-add-spinner-for-bos-component-as-it-feels-broken-when-data-is-fetching branch July 18, 2024 18:12
This was referenced Jul 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgsmccauley morgsmccauley morgsmccauley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add spinner for BOS component as it feels 'broken' when data is fetching
2 participants
@Kevin101Zhang @morgsmccauley