Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize test path #123

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Canonicalize test path #123

merged 2 commits into from
Nov 30, 2023

Conversation

aborg-dev
Copy link

@aborg-dev aborg-dev commented Nov 30, 2023 •
edited
Loading

If user passes path with a trailing slash, this would result in different keys in the test_summary.csv path and lead to duplicates.

So we normalize the passed path.

Fixes #122

@aborg-dev aborg-dev mentioned this pull request Nov 30, 2023
Closed
@aborg-dev aborg-dev added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit ab7d7bf Nov 30, 2023
21 checks passed
@aborg-dev aborg-dev deleted the canonical_path branch November 30, 2023 17:13
@aborg-dev aborg-dev added this to the ZK WASM: Stage 1 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCJOHN974 MCJOHN974 MCJOHN974 approved these changes

Assignees

@MCJOHN974 MCJOHN974

Labels
None yet
Projects
None yet
Milestone
ZK WASM: Stage 1
Development

Successfully merging this pull request may close these issues.

Strange line in test_summary.csv
2 participants
@aborg-dev @MCJOHN974