-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autocannon-compare-cli package #790
Conversation
No linked issues found. Please add the corresponding issues in the pull request description. |
Add tests. Add percentage diff. Show bytes in a more friendly way.
@codeflyer @simone-sanfratello can you please take a look? |
Nice! I'd add the option to rename the columns, sometimes it's hard to remember which one is "a" and which one is "b" and it's convenient to have for example "current" and "next"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we include using this in the Web UI then?
I think that's a good idea. Should make it way easier to use it that way. |
That was my original request! 🚀 |
Create new compare route on backend. Refactor and polishing.
I've updated the backend with a new route to return the new comparison, but the frontend changes are still missing. |
This now is partially implemented on the frontend, it's using the new route and showing the results in a table but could use some improvements on styling like adding color to the results. I kept the old compare route intact and created a |
@guilhermelimak where do we stand with this PR? |
@simoneb should be ready for reviewing and testing, there's the point I mentioned on my previous comment about some data we had on the previous compare function and we don't have on the new one but should be good to go if that's fine |
Add a small cli utilty to compare autocannon results.
You can see a preview of the comparison here:
Closes nearform/hub-draft-issues#172