Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for ES* password protected private keys #119

Merged
merged 6 commits into from
Nov 2, 2021

Conversation

radomird
Copy link
Contributor

@radomird radomird commented Nov 1, 2021

Adding support for the password protected private keys that use the ES* (ES256, ES384 and ES512) algorithms.

Closes #118

src/signer.js Outdated Show resolved Hide resolved
src/signer.js Outdated Show resolved Hide resolved
@radomird radomird marked this pull request as ready for review November 2, 2021 14:08
@radomird radomird requested a review from simoneb November 2, 2021 14:29
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Simone Busoli <simone.busoli@nearform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for password protected keys using the ES* algorithms
4 participants