Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix benchmarks #186

Merged
merged 6 commits into from
Jan 24, 2022
Merged

fix benchmarks #186

merged 6 commits into from
Jan 24, 2022

Conversation

hails
Copy link
Contributor

@hails hails commented Jan 24, 2022

This PR converts the benchmark CommonJS modules into ES modules so we can use cronometro properly.
Closes #185

@hails hails self-assigned this Jan 24, 2022
@hails hails mentioned this pull request Jan 24, 2022
Merged
mcollina
mcollina approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hails hails merged commit 84f2772 into master Jan 24, 2022
@hails hails deleted the fix/benchmarks branch January 24, 2022 10:14
@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Closed
This was referenced Feb 17, 2022
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

@hails hails

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's not possible to run the benchmarks, issues with cronometro and ES Modules
2 participants
@hails @mcollina