Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Organization & teams create callback handling #560

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

allbto
Copy link
Contributor

@allbto allbto commented Jan 11, 2019

Hi @mihaidma

Just a small PR for Udaru.
I had a small issue where calling:

await udaru.organizations.create(organization, { createOnly: true })

would ignore my 2 param { createOnly: true }.

My current working workaround is:

await udaru.organizations.create(organization, { createOnly: true }, true)

to skip the missing callback check.

But I thought I would contribute back to fix this small issue.
Let me know if you have any question.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Coverage Status

Coverage increased (+0.005%) to 93.153% when pulling dc3dc93 on allbto:hotfix/create-resources-callback into b18963b on nearform:master.

@mihaidma
Copy link
Contributor

mihaidma commented Feb 4, 2019

Thank you @allbto for the contribution, looks good. Sorry for the late reply. Will merge it and start preparing a release

@mihaidma mihaidma merged commit 6e02cd7 into nearform:master Feb 4, 2019
@allbto allbto deleted the hotfix/create-resources-callback branch February 5, 2019 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants