Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App Launcher Create App Form based on new design #146

Merged
merged 26 commits into from
Mar 6, 2024
Merged

Update App Launcher Create App Form based on new design #146

merged 26 commits into from
Mar 6, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Mar 5, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-03-05 at 7 49 36 PM Screenshot 2024-03-05 at 7 49 48 PM Screenshot 2024-03-05 at 7 49 57 PM Screenshot 2024-03-05 at 8 45 59 PM

Any other comments?

  • Moved app create and edit form to its own page
  • Updated App Form to utilize MUI components
  • Updates to Server Types page for new app forms
  • Misc styling updates
  • Fixed issue causing env variables to load incorrectly into edit form

Copy link

vercel bot commented Mar 5, 2024

@jbouder is attempting to deploy a commit to the nebari-jhub-apps Team on Vercel.

A member of the Team first needs to authorize it.

ui/src/App.tsx Show resolved Hide resolved
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:13pm

@jbouder jbouder marked this pull request as ready for review March 6, 2024 01:06
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment, other than that it looks great to me! 🎉

@aktech aktech merged commit 6a5df08 into nebari-dev:main Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants