Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates on Slurm config and some linter small rollbacks #150

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

viniciusdc
Copy link
Collaborator

@viniciusdc viniciusdc commented Mar 1, 2024

Reference Issues or PRs

closes #145

What does this implement/fix?

I had some errors with Ansible not addressing the restart tasks correctly due to Case-matching issues (this only affects redeployments, so was a bit tricky to find on first glance). Also, we made the base directory of the Slurm installation into a variable, as our test's default path may differ from user installation into pre-existing machines.

I also included some comments from the slurm-related package man docs on file permissions for future reference.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@aktech
Copy link
Member

aktech commented Mar 14, 2024

Slurm config changes and linting changes are very orthogonal pieces and I would recommend to keep them in separate PRs. I also see some CI changes in here.

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@aktech aktech merged commit 3652d50 into main Mar 15, 2024
3 checks passed
@aktech aktech deleted the vini-test-condarc branch March 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Recent deployment with libvirt on Ubuntu2004 test failed
2 participants