Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: improve unit test workflow in CI, revert #2046 #2071

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 16, 2023

Reference Issues or PRs

xref: #1128

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

The original goal of this PR is to reduce the installation time. But then I discovered that we were not really testing multiple Python versions. When the CI is configured correctly, the Python 3.12 build from #2046 will not work due to the lack of wheels for conda-build and multiple other dependencies for Python 3.12.

In this PR, I reverted #2046, fixed the unit test build so it actually ran on different Python versions, added auto cancelation, and reduced the installation time from ~20min to ~ 1min.

@fangchenli fangchenli changed the title CI: imporve nebari installation in CI CI: improve unit test workflow in CI, revert #2046 Oct 16, 2023
@fangchenli fangchenli marked this pull request as ready for review October 16, 2023 22:08
@fangchenli fangchenli added the impact: high 🟥 This issue affects most of the nebari users or is a critical issue label Oct 17, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @fangchenli!

Screenshot 2023-10-17 at 19 15 29

vs now:

Screenshot 2023-10-17 at 19 18 05

@iameskild iameskild merged commit 6846643 into nebari-dev:develop Oct 18, 2023
9 checks passed
@fangchenli fangchenli deleted the improve-ci branch October 22, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD 👷🏽‍♀️ area:developer-experience 👩🏻‍💻 impact: high 🟥 This issue affects most of the nebari users or is a critical issue
Projects
Development

Successfully merging this pull request may close these issues.

2 participants