Fixing for windows #77
Conversation
…FixingForWindows # Conflicts: # src/test/groovy/nebula/test/ChangingTestDirSpec.groovy # src/test/groovy/nebula/test/functional/GradleRunnerSpec.groovy Also made the tests run on windows and should run on linux. Need to test that still.
|
As i said before, you may want to consider adding appveyor to the checks routine for all of Nebula. Unfortunately, I'm one of the poor lost souls that have to run on Winblows and any time i crack Nebula open, I encounter a Winblows related error. I think I got them all out of this, but the gradle tests stuff is horribly old, don't want to get into that and very few unit tests check for gradle 3.x compatibility. That stuff is beyond me at the moment tho. Its a shame because I have some major overhauls that I could do to this library to significantly enhance its capabilities, Its just got to be brought up to the 3.x stuff, my stuff would be hard pressed to work on 2.x |
|
And if we could please get this in as quickly as possible, i would appreciate it. I had to make these changes to address bugs I found in Nebula-Publish. I can't get those changes merged until these changes are merged and released and the Nebula-Publish issues have me dead in the water at the moment. Please let me know what i can do to speed this up. Thanks |
|
It looks like when you merge this, you will also have to update nebula-plugin-plugin to pull the correct version. In my testing of nebula-publish i have to do some pretty nasty things to get around plugin-plugins dependencies. |
|
Its been 6 days, can someone give me a status on this MR? Code review? Something? This has me at a stand still and I'm running out of busy work. Thanks |
|
in case your wondering, i need this merged and nebula-plugin updated so i can finish this PR nebula-plugins/nebula-publishing-plugin#71 |
|
thanks @szpak , im hoping i can avoid that, as everything is so interconnected, i would basically have to pull nearly all of nebula in house and start running my own builds. I REALLY don't want to do that. |
|
Our new plugins are planned to use gradle testKit for testing so as we migrate more and more of them over to that, this project will become more and more helpers for testKit. |
|
That's great. But can we get this issue clears in the mean time so I can finish fixing publish? |
.gitignore
Outdated
| @@ -8,3 +8,4 @@ gradle.properties | |||
| *.iml | |||
| *.iws | |||
| out/ | |||
| test/ | |||
There was a problem hiding this comment.
Remove this, I'll fix the test that is writing outside of the build directory
| @@ -23,7 +24,12 @@ class SpecifiedGradleVersionIntegrationSpec extends IntegrationSpec { | |||
| when: | |||
| def result = runTasksSuccessfully('build') | |||
| then: | |||
| result.standardOutput.contains("gradle/$requestedGradleVersion/taskArtifacts") | |||
| if (Os.isFamily(Os.FAMILY_WINDOWS)){ | |||
There was a problem hiding this comment.
There is a spock construct to do this. I'd rather have 2 separate tests that require different OS's then an if block in the test.
http://spockframework.org/spock/docs/1.0/extensions.html
IgnoreIf block
os Information about the operating system (see spock.util.environment.OperatingSystem)
There was a problem hiding this comment.
oh i know the ignoreif annotation, i just hate the dup code is all. but if you want two tests, no problem, i can do that. And as i write this, i just realized how to pull it off. give me a few minutes
There was a problem hiding this comment.
ok, so my brilliant idea wasn't so brilliant. its 2 tests now.
Expands on Vampire's code and fixes more bugs associated with running on windows