Add make_default method on AddPaymentSourcesToWallet class #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vassalloandrea
changed the title
last_credit_card_as_default preference on Spree::Config
vassalloandrea
force-pushed
the
last_payment_source_as_default_for_user_wallet
branch
from
774691f
to
38b18f9
Compare
vassalloandrea
changed the title
vassalloandrea
force-pushed
the
last_payment_source_as_default_for_user_wallet
branch
from
38b18f9
to
44e5e20
Compare
vassalloandrea
force-pushed
the
last_payment_source_as_default_for_user_wallet
branch
from
44e5e20
to
48dd2fe
Compare
vassalloandrea
force-pushed
the
last_payment_source_as_default_for_user_wallet
branch
from
48dd2fe
to
3f9a3ed
Compare
Move the logic to make the last payment source as default outside the add_to_wallet method to take advantage if someone wants to change only the make default behavior.
vassalloandrea
force-pushed
the
last_payment_source_as_default_for_user_wallet
branch
from
3f9a3ed
to
27fb811
Compare
AlessioRocco
deleted the
last_payment_source_as_default_for_user_wallet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: solidusio#2652
Update:
After some consideration with @tvdeyen
With this PR we want to separate the
add_to_walletbehavior from themake_defaultone to help if someone wants to change only themake_defaultlogic without overriding theadd_to_wallet.How it works
Now the
add_to_walletmethod calls themake_defaultmethod after adding on the user wallet the payment sources.To change the
make_defaultbehavior now we can create own class and override themake_defaultmethod.E.g.: solidusio#2913 (comment)