Decouple fmt and spdlog dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls-1801
approved these changes
Sep 27, 2024
nautilus/CMakeLists.txt
Outdated
| @@ -32,6 +32,9 @@ set_target_properties(nautilus PROPERTIES | |||
| EXPORT_NAME nautilus | |||
| ) | |||
|
|
|||
| disable_target_warnings(fmt) | |||
There was a problem hiding this comment.
should this be here? it causes an cmake error if external fmt is used
There was a problem hiding this comment.
I moved this. It should work now.
This should make it possible to decouple the formating and logging in nautilus.
PhilippGrulich
force-pushed
the
use_external_fmt
branch
from
5de130a
to
7499efb
Compare
keyseven123
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fmt as its own dependency instead of the one included by spdlog.
This should make it possible to decouple the formating and logging in nautilus.