Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera not working properly with Galacticraft #36

Closed
ultra421 opened this issue Mar 24, 2020 · 5 comments
Closed

Camera not working properly with Galacticraft #36

ultra421 opened this issue Mar 24, 2020 · 5 comments
Assignees
@necauqua
Labels
bug When a mod does not work correctly in some way, except crashing the game confirmed When mod author experienced the bug/whatever himself mod compat When bugs or crashes are caused when having this mod together with some other mod

Comments

@ultra421
Copy link

Description
Camera not going up/down according to size, fog changes according to size.

To reproduce
Using any size recalibrator

Expected behavior
Camera going up/down.

Screenshots
1 to 1
1 to 2
1 to 32

Additional information:
@ultra421 ultra421 added the bug When a mod does not work correctly in some way, except crashing the game label Mar 24, 2020
@necauqua
Copy link
Owner

Well this is one of the main functions of the mod which obviously worked, so this must be caused by yet another mod compatibility issue, I will check your mods too at some point.

@minimutson
Copy link

minimutson commented Jun 22, 2020 •
edited
Loading

Same issue, but the only mod I have found to be common ground is
MicdoodlePlugin (MicdoodleCore-1.12.2-4.0.2.244.jar)

(Edit)
Upon further testing, I have reached the conclusion that MicdoodlePlugin (MicdoodleCore-1.12.2-4.0.2.244.jar) is the culprit of the camera issue. I hope this helped!

-minimutson 6/21/2020 10:40 PM EST

@necauqua
Copy link
Owner

This helped :)

@necauqua necauqua added the mod compat When bugs or crashes are caused when having this mod together with some other mod label Jun 23, 2020
@necauqua necauqua added the confirmed When mod author experienced the bug/whatever himself label Jul 27, 2020
@necauqua
Copy link
Owner

confirmed by @LorenzoPapi on discord

@necauqua necauqua changed the title Camera not working properly Camera not working properly with Galacticraft Jan 21, 2021
@necauqua necauqua mentioned this issue Jan 21, 2021
Closed
necauqua added a commit that referenced this issue Feb 3, 2021
@necauqua
Insane and dumb year-bulk commit, the Mixin rewrite and a ton of fixe…
ede2651 
…s and features (notably particles)

added:
  - Particle scaling - most entity particles (running, falling, mob death cloud etc.) are now scaled to the size of the source entity
  - Most of entities spawned by other entities (babies, xp orbs, fireballs etc.) have their size set to the size of "parent" entity
  - Potions(and their area of effect), xp bottles, ender pearls and eyes, snowballs and arrows are now scaled flawlessly
  - Entity 'mass' (amount of being pushed by other entities and knockback) is now scaled
  - /sizeof command now can specify the number of ticks that the resizing process should take
  - Sword sweep attack radius is now scaled
  - Entity attack knockback is now scaled
  - Only the same-size animals can mate
  - Spawn egg spawns entities with the same size as you are
  - Spawn egg used on an entity spawns a child with same size as the entity
  - Breaking blocks when big will yield big drops (that already was the case with small sizes)
  - Some minor entity AI improvements for scaled mobs
  - Gamerules for the default entity and player sizes, gamerule to keep size after death (#14)
  - Config option to allow using recalibrators on other players against their will (#20)
  - Config option to allow small players to use beds (#67)
  - Scale the mob health labels from the Neat mod (can disable in config)
fixed:
  - (!) Changed how network synchronization works - resolved virtually all desync problems
  - (!) Improved general mod compatibility (fixed a ton of unreported mod compat crashes in advance)
  - (!) Fix the crash with OptiFine (#16, #61)
  - (!) Fix the crash with old Forge (the IRarity class not found error)
  - Fix player getting stuck if his size is set every tick (e.g. by a command block) (#66)
  - Fix player warping back to the bed after waking up, moving away and changing size (#74)
  - Fix standing near lava when small setting you on fire (#50)
  - Fix getting pushed away when being under a block (#55)
  - Fix player body walking direction animation when small
  - Fix some mobs melee attack radius being unaffected by their scale (blazes, spiders)
  - Fix big entities way too quickly and noticeably disappearing with distance (#77)
  - Fix big entities shadows (mostly)
  - Fix various vanilla mob rendering quirks (leashes, guardian beams etc.)
  - Fix the borked recipe that any two items without a recipe together made `Antipolarized Concentrated Pym essence` (#28)
  - Fix camera and other issues with Galacticraft (#36) and RandomPatches mods
  - Fix big white box rendering over player when sitting on furniture from MrCrayfish Furniture Mod (#79)
  - Fix a ton of mod compat crashes: OptiFine (already mentioned), Spigot (also Mohist, #52), any Mixin mods (MalisisDoors etc., #21), iChun mods (#31), VanillaFix (#49), Quark (#32), BetterFps (#48), AstralSorcery (#73) and many more
@necauqua
Copy link
Owner

necauqua commented Feb 3, 2021

Fixed in ede2651

@necauqua necauqua closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@necauqua necauqua

Labels
bug When a mod does not work correctly in some way, except crashing the game confirmed When mod author experienced the bug/whatever himself mod compat When bugs or crashes are caused when having this mod together with some other mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@necauqua @ultra421 @minimutson