Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text: onLongPress support #1011

Closed
chrisdrackett opened this issue Jun 28, 2018 · 3 comments
Closed

Text: onLongPress support #1011

chrisdrackett opened this issue Jun 28, 2018 · 3 comments
Labels
resolution: wontfix
Milestone
0.12.0

Comments

@chrisdrackett
Copy link
Contributor

The problem

When I add a onLongPress event to a text node I can't get the event to fire on a long press

How to reproduce

Simplified test case: https://codesandbox.io/s/6w34l63jw

Steps to reproduce:

  1. Long press on text

Expected behavior

console will long "long press!"

Environment (include versions). Did this work in previous versions?

  • React Native for Web (version): 0.7.3
  • React (version): 16.4.0
  • Browser: Safari / Chrome
@necolas
Copy link
Owner

necolas commented Jun 28, 2018

Yes, that's mentioned in the compatibility table https://github.com/necolas/react-native-web#compatibility-with-react-native

@chrisdrackett
Copy link
Contributor Author

Oops! Sorry about that!

@necolas necolas changed the title onLongPress does not work on text node Text: onLongPress support Jul 7, 2018
@necolas necolas added this to the 0.10.0 milestone Nov 13, 2018
@necolas necolas mentioned this issue Nov 17, 2018
Closed
44 tasks
DaKaZ pushed a commit to DaKaZ/react-native-web that referenced this issue Jan 26, 2019
add onLongPress support to text, fixes issue necolas#1011
ca2ede6
@DaKaZ DaKaZ mentioned this issue Jan 26, 2019
Closed
DaKaZ pushed a commit to DaKaZ/react-native-web that referenced this issue Mar 4, 2019
Fix issue necolas#1011 - adds touchable event handlers to text
06557c6
@DaKaZ DaKaZ mentioned this issue Mar 4, 2019
Closed
@necolas necolas modified the milestones: 0.11.0, 0.12.0 Mar 6, 2019
@necolas necolas self-assigned this Jul 2, 2019
@necolas
Copy link
Owner

necolas commented Oct 7, 2019

Decided to close this as "wontfix" because the primitive Text component should be simple and fast, which I don't think is the case when it include built-in touch handling, and it could cause regressions for apps like Twitter Lite #1272 (comment).

@necolas necolas closed this as completed Oct 7, 2019
@necolas necolas removed their assignment Oct 7, 2019
@parasharrajat parasharrajat mentioned this issue Nov 22, 2021
Merged
5 tasks
@fedirjh fedirjh mentioned this issue Oct 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution: wontfix
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@chrisdrackett @necolas