Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement onWheel to fix inverted scrolling #1241

Closed
wants to merge 4 commits into from
Closed

Re-implement onWheel to fix inverted scrolling #1241

wants to merge 4 commits into from

Commits on Feb 5, 2019

  1. Re-implement onWheel to fix inverted scrolling

    @danalloway
    danalloway committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    daef00a View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. fix for jumpy scrolling 

    Brave on Windows has a jump scroll, delaying the scroll adjustment my a tick fixes the issue without introducing anything noticeable across other browsers / platforms
    @danalloway
    danalloway authored Feb 19, 2019
    Configuration menu
    Copy the full SHA
    7a49a31 View commit details
    Browse the repository at this point in the history

  2. forgot to invert the older wheelDelta value if it's present

    @danalloway
    danalloway authored Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ee2b41f View commit details
    Browse the repository at this point in the history

  3. fix priority on scroll delta property 

    prefer delta over wheelDelta
the values they report are not the same (my mistake) so correct my previous commit
    @danalloway
    danalloway authored Feb 19, 2019
    Configuration menu
    Copy the full SHA
    6c8cde6 View commit details
    Browse the repository at this point in the history