Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to save final BiLSTM-CRF model when training on a train-subset #38

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

jantrienes
Copy link
Collaborator

@jantrienes jantrienes commented Oct 7, 2020

When training on a sample of the training data, we previously never saved the final model (for space reasons). This might be undesirable, as it can be useful to evaluate the model in a downstream task.

This PR adds an optional flag to persist the final model. Not passing the flag will keep existing behavior (save_final_model=False).

@jantrienes jantrienes requested a review from AIessa October 7, 2020 12:33
Copy link
Contributor

@AIessa AIessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is no default or default is True? Either way, this seems like a good solution :)

@jantrienes
Copy link
Collaborator Author

Thanks! The default is False, and passing the flag will change it to True.

@jantrienes jantrienes merged commit 953df33 into master Oct 7, 2020
@jantrienes jantrienes deleted the bilstmcrf-save-final-model branch October 7, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants