Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fine-tuning and embedding language flags #40

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Conversation

AIessa
Copy link
Contributor

@AIessa AIessa commented Oct 13, 2020

  1. added option to set embedding language to Dutch even if not using ons as corpus
  2. bilstmcrf_run.py also has option to continue training with existing model (but maybe it's better to re-use '--model_file' + bool '--continue_training'?)

@jantrienes jantrienes changed the title Set embed lang Add flag for fine-tuning and option to set embedding lang Nov 9, 2020
@jantrienes jantrienes changed the title Add flag for fine-tuning and option to set embedding lang Add fine-tuning flag and option to set embedding lang Nov 9, 2020
@jantrienes jantrienes changed the title Add fine-tuning flag and option to set embedding lang Add fine-tuning and embedding language flags Nov 9, 2020
@jantrienes
Copy link
Collaborator

This is a nice addition, thanks for the PR @AIessa.

but maybe it's better to re-use '--model_file' + bool '--continue_training'?

I agree with you on that, and changed the implementation accordingly.

@jantrienes jantrienes merged commit 040713c into master Nov 9, 2020
@jantrienes jantrienes deleted the set_embed_lang branch November 9, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants