Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matcher-combinators in-any-order with timeout #28

Merged
merged 4 commits into from
Oct 8, 2020
Merged

matcher-combinators in-any-order with timeout #28

merged 4 commits into from
Oct 8, 2020

Conversation

thumbnail
Copy link
Member

@thumbnail thumbnail commented Jun 4, 2020 •
edited

Brief

drop-in replacement for #'matcher-combinator.matchers/in-any-order which times out after a (configurable) timeout. This should prevent hanging tests when the amount of possible permutations is high.

in cljs this is just an transparent call to matcher-combinators/in-any-order.

TODO

  • add cljs compatibility
    • this seems impossible as cljs/js has no way to block an async operation

QA plan

run in several projects to confirm behaviour

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)
      • arguably :P

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

vemv
vemv reviewed Jun 4, 2020
View reviewed changes
src/nedap/utils/test/impl.cljc Outdated Show resolved Hide resolved
src/nedap/utils/test/matchers.clj Outdated Show resolved Hide resolved
src/nedap/utils/test/matchers.clj Outdated Show resolved Hide resolved
test/unit/nedap/utils/test/matchers.clj Outdated Show resolved Hide resolved
test/unit/nedap/utils/test/matchers.clj Outdated Show resolved Hide resolved
@thumbnail thumbnail force-pushed the matcher-combinators-matcher branch 2 times, most recently from 7694be7 to b9baf62 Compare June 4, 2020 11:12
@thumbnail thumbnail mentioned this pull request Jun 15, 2020
Open
@thumbnail thumbnail mentioned this pull request Aug 21, 2020
Closed
@thumbnail thumbnail mentioned this pull request Sep 29, 2020
Closed
@thumbnail thumbnail force-pushed the matcher-combinators-matcher branch 3 times, most recently from 9f68f69 to 71d7940 Compare October 6, 2020 16:14
@thumbnail thumbnail marked this pull request as ready for review October 6, 2020 16:26
@thumbnail thumbnail requested a review from a team October 6, 2020 16:26
jwkoelewijn
jwkoelewijn approved these changes Oct 7, 2020
View reviewed changes
test/unit/nedap/utils/test/matchers.cljc Outdated Show resolved Hide resolved
josefigueroa-nedap
josefigueroa-nedap approved these changes Oct 8, 2020
View reviewed changes
Copy link

@josefigueroa-nedap josefigueroa-nedap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 👍

@thumbnail thumbnail merged commit 4d3e1af into master Oct 8, 2020
@thumbnail thumbnail deleted the matcher-combinators-matcher branch October 8, 2020 12:38
@thumbnail thumbnail mentioned this pull request Oct 8, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwkoelewijn jwkoelewijn jwkoelewijn approved these changes

@vemv vemv vemv left review comments

@lennartbuit lennartbuit lennartbuit left review comments

@josefigueroa-nedap josefigueroa-nedap josefigueroa-nedap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thumbnail @jwkoelewijn @vemv @josefigueroa-nedap @lennartbuit