Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8.0 #35

Merged
merged 1 commit into from
Oct 8, 2020
Merged

v1.8.0 #35

merged 1 commit into from
Oct 8, 2020

Conversation

thumbnail
Copy link
Member

@thumbnail thumbnail commented Oct 8, 2020 •
edited by jwkoelewijn
Loading

Delivers:

Release checklist (author)

  • All PRs / relevant commits since the previous release are listed in this PR's description
  • The new proposed version follows semver
  • The build passes
  • New features are (briefly) reflected in the README

Release checklist (reviewer)

  • All PRs / relevant commits since the previous release are listed in this PR's description
  • The new proposed version follows semver
  • New features are (briefly) reflected in the README

@thumbnail thumbnail requested a review from a team October 8, 2020 12:44
jwkoelewijn
jwkoelewijn approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@jwkoelewijn jwkoelewijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please browse the public namespaces, which are documented, speced and tested.

I guess this line in the current Readme prevents me from suggesting adding some documentation about the new features ;)

@thumbnail
Copy link
Member Author

4d3e1af did actually adjust the README too, by adding the ns ;)

@thumbnail thumbnail merged commit 1a22ebe into master Oct 8, 2020
@thumbnail thumbnail deleted the v1.8.0 branch October 8, 2020 13:33
@tcoenraad
Copy link
Contributor

tcoenraad commented Oct 8, 2020 •
edited
Loading

Your delivers will not be copied by ncrw, would it?

@thumbnail
Copy link
Member Author

Your delivers will not be copied by ncrw, would it?

It will (and currently is), we're on ncrw v1.11.0 which has that feature

@jwkoelewijn
Copy link
Member

4d3e1af did actually adjust the README too, by adding the ns ;)

That deserved you the "vinkje"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwkoelewijn jwkoelewijn jwkoelewijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thumbnail @tcoenraad @jwkoelewijn