Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect-match? #30

Closed
thumbnail opened this issue Sep 29, 2020 · 0 comments · Fixed by #32
Closed

expect-match? #30

thumbnail opened this issue Sep 29, 2020 · 0 comments · Fixed by #32

Comments

@thumbnail
Copy link
Member

Context

The expect helper is locked to use meta= internally. This has a couple of disadvantages;

  • lack of flexibility.
  • cloverage uses metadata to measure coverage; breaks expect-tests.

Task

  1. add matcher-combinators namespace (see matcher-combinators in-any-order with timeout #28)
  2. add expect-match? which uses matcher-combinators.core/match for the :form-assertion, and matcher-combinators.test/match? for the :to assertion.

Additional resources

https://github.com/nubank/matcher-combinators
thumbnail added a commit that referenced this issue Sep 29, 2020
@thumbnail
Configurable matcher for expect.
69b91ba 
prep for #30
@thumbnail thumbnail mentioned this issue Oct 1, 2020
Merged
26 tasks
thumbnail added a commit that referenced this issue Oct 1, 2020
@thumbnail
add match? expect-matcher
a1d872b 
fixes #30
@thumbnail thumbnail mentioned this issue Oct 1, 2020
Merged
26 tasks
@thumbnail thumbnail linked a pull request Oct 1, 2020 that will close this issue
add matcher-combinators/match? support to expect #32
Merged
26 tasks
thumbnail added a commit that referenced this issue Oct 1, 2020
@thumbnail
add match? expect-matcher
5938d4d 
fixes #30
thumbnail added a commit that referenced this issue Oct 1, 2020
@thumbnail
add match? expect-matcher
0f9d432 
fixes #30
thumbnail added a commit that referenced this issue Oct 2, 2020
@thumbnail
add match? expect-matcher
a5c2b28 
fixes #30
thumbnail added a commit that referenced this issue Oct 6, 2020
@thumbnail
add match? expect-matcher
3830652 
fixes #30
thumbnail added a commit that referenced this issue Oct 6, 2020
@thumbnail
add :with option to expect (#31)
c898fed 
* Configurable matcher for expect.

prep for #30

* fix docstring

* formatting + docstring

* Add expect :with = tests

* bump ncrw to 1.11.0

* no tests reside in src/

* Fix cljs compatibility

* add matcher-combinators as provided dep

* more elaborate assertions for expect-matcher results

* bump matcher-combinators

* add configurable failure messages

* fix typo
thumbnail added a commit that referenced this issue Oct 6, 2020
@thumbnail
add match? expect-matcher
c63489c 
fixes #30
thumbnail added a commit that referenced this issue Oct 6, 2020
@thumbnail
add matcher-combinators/match? support to expect (#32)
f7650f0 
* add match? expect-matcher

fixes #30

* fix cljs tests

matcher-combinators returns different results for cljs

* change order on matcher-predicate

expected value first, actual value second. as is convention

* bump deps

statisfy pedantic with ncrw

* add matcher/in-any-order test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add matcher-combinators/match? support to expect nedap/utils.test
1 participant
@thumbnail