Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: run fmt -w . to prevent warning msgs #67

Merged
merged 3 commits into from
Dec 4, 2023
Merged

all: run fmt -w . to prevent warning msgs #67

merged 3 commits into from
Dec 4, 2023

Conversation

dnkdev
Copy link
Contributor

@dnkdev dnkdev commented Nov 26, 2023

format all files, to get rid of V's warnings (attribute new syntax)

nedpals
nedpals requested changes Nov 28, 2023
View reviewed changes
Copy link
Owner

@nedpals nedpals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that the formatting specific to import statements that I have commented be removed.

ctx/ctx.v Outdated Show resolved Hide resolved
picoserver/server.v Outdated Show resolved Hide resolved
router/router.v Outdated Show resolved Hide resolved
router/router_test.v Outdated Show resolved Hide resolved
server/server.v Outdated Show resolved Hide resolved
session/session.v Outdated Show resolved Hide resolved
session/session.v Outdated Show resolved Hide resolved
utils/utils.v Outdated Show resolved Hide resolved
@dnkdev
Copy link
Contributor Author

dnkdev commented Nov 28, 2023 •
edited
Loading

You absolutely right, problems could appear if path to module is changed. :) Should be ok now.

@dnkdev dnkdev requested a review from nedpals November 30, 2023 06:30
nedpals
nedpals previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@nedpals nedpals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Had to bump the version in your branch since the formatting will break previous language version

This was referenced Dec 4, 2023
Closed
Closed
@dnkdev
Copy link
Contributor Author

dnkdev commented Dec 4, 2023 •
edited
Loading

So the #69 is here now, and I decided put #68 picoserver changes also here, it affects a picoserver example, which should compile altogether. I made a VEX 0.3.6, just forgot to pull before make changes, thats why force push.

@dnkdev dnkdev requested a review from nedpals December 4, 2023 11:24
@nedpals
Copy link
Owner

nedpals commented Dec 4, 2023

Tests are green now. LGTM!

@nedpals nedpals merged commit 2e1ba86 into nedpals:master Dec 4, 2023
4 checks passed
@dnkdev dnkdev deleted the fmt-fix branch December 5, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedpals nedpals Awaiting requested review from nedpals

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkdev @nedpals